Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] update firewall docs for Cloud Firewalls #459

Merged
merged 6 commits into from
Aug 22, 2024
Merged

Conversation

AshleyDumaine
Copy link
Contributor

What this PR does / why we need it: Follow-up from #451

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 15, 2024
rahulait
rahulait previously approved these changes Aug 16, 2024
komer3
komer3 previously approved these changes Aug 21, 2024
@AshleyDumaine AshleyDumaine dismissed stale reviews from komer3 and rahulait via 36dd667 August 21, 2024 19:12
@AshleyDumaine AshleyDumaine requested a review from rahulait August 21, 2024 19:12
@AshleyDumaine AshleyDumaine requested a review from komer3 August 21, 2024 19:12
komer3
komer3 previously approved these changes Aug 21, 2024
@eljohnson92 eljohnson92 merged commit 0fff403 into main Aug 22, 2024
11 checks passed
@AshleyDumaine AshleyDumaine deleted the firewall-docs branch August 22, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants